Merge pull request #1391 from kade-robertson/patch-1

fix: update chromedriver download URL, resolve test issues
master
Jesper Håkansson 10 months ago committed by GitHub
commit 2e4c661d49
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      .github/workflows/test.yml
  2. 2
      src/test/webdriver/chromedriver.rs
  3. 4
      tests/all/log_level.rs

@ -30,6 +30,8 @@ jobs:
steps: steps:
- uses: actions/checkout@v3 - uses: actions/checkout@v3
- uses: nanasess/setup-chromedriver@master - uses: nanasess/setup-chromedriver@master
- if: matrix.os == 'macos-latest'
run: brew install --cask firefox
- uses: dtolnay/rust-toolchain@stable - uses: dtolnay/rust-toolchain@stable
with: with:
toolchain: ${{ matrix.rust }} toolchain: ${{ matrix.rust }}

@ -156,7 +156,7 @@ fn fetch_chromedriver_version() -> Result<String> {
fn assemble_chromedriver_url(chromedriver_version: &str, target: &str) -> String { fn assemble_chromedriver_url(chromedriver_version: &str, target: &str) -> String {
format!( format!(
"https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/{version}/{target}/chromedriver-{target}.zip", "https://storage.googleapis.com/chrome-for-testing-public/{version}/{target}/chromedriver-{target}.zip",
version = chromedriver_version, version = chromedriver_version,
target = target, target = target,
) )

@ -16,7 +16,9 @@ fn matches_info() -> impl Predicate<str> + PredicateReflection {
} }
fn matches_cargo() -> impl Predicate<str> + PredicateReflection { fn matches_cargo() -> impl Predicate<str> + PredicateReflection {
contains("Finished release [optimized] target(s) in ") contains("Finished release [optimized] target(s) in ").or(contains(
"Finished `release` profile [optimized] target(s) in ",
))
} }
#[test] #[test]

Loading…
Cancel
Save