Merge branch 'bradyjoslin-fix-cargo-installation'

master
Jesper Håkansson 4 years ago
commit 9e210db1de
  1. 14
      src/install/mod.rs

@ -198,8 +198,9 @@ fn prebuilt_url(tool: &Tool, version: &str) -> Result<String, failure::Error> {
}, },
Tool::CargoGenerate => { Tool::CargoGenerate => {
Ok(format!( Ok(format!(
"https://github.com/ashleygwilliams/cargo-generate/releases/download/v{0}/cargo-generate-v{0}-{1}.tar.gz", "https://github.com/cargo-generate/cargo-generate/releases/download/v{0}/cargo-generate-v{0}-{1}.tar.gz",
Krate::new(&Tool::CargoGenerate)?.max_version, // Krate::new(&Tool::CargoGenerate)?.max_version,
"0.5.1", // latest released binary [#907](https://github.com/rustwasm/wasm-pack/issues/907)
target target
)) ))
}, },
@ -257,14 +258,17 @@ pub fn cargo_install(
_ => tool.to_string(), _ => tool.to_string(),
}; };
let mut cmd = Command::new("cargo"); let mut cmd = Command::new("cargo");
cmd.arg("install") cmd.arg("install")
.arg("--force") .arg("--force")
.arg(crate_name) .arg(crate_name)
.arg("--version")
.arg(version)
.arg("--root") .arg("--root")
.arg(&tmp); .arg(&tmp);
if version != "latest" {
cmd.arg("--version").arg(version);
}
let context = format!("Installing {} with cargo", tool); let context = format!("Installing {} with cargo", tool);
child::run(cmd, "cargo install").context(context)?; child::run(cmd, "cargo install").context(context)?;
@ -274,7 +278,7 @@ pub fn cargo_install(
// little renaming here. // little renaming here.
let binaries: Result<Vec<&str>, failure::Error> = match tool { let binaries: Result<Vec<&str>, failure::Error> = match tool {
Tool::WasmBindgen => Ok(vec!["wasm-bindgen", "wasm-bindgen-test-runner"]), Tool::WasmBindgen => Ok(vec!["wasm-bindgen", "wasm-bindgen-test-runner"]),
Tool::CargoGenerate => Ok(vec!["cargo-genrate"]), Tool::CargoGenerate => Ok(vec!["cargo-generate"]),
Tool::WasmOpt => bail!("Cannot install wasm-opt with cargo."), Tool::WasmOpt => bail!("Cannot install wasm-opt with cargo."),
}; };

Loading…
Cancel
Save