Merge pull request #424 from fitzgen/issue-422

Issue 422

src/build.rs

@@ -82,7 +82,7 @@ pub fn cargo_build_wasm(
         cmd.arg("--release");
     }
     cmd.arg("--target").arg("wasm32-unknown-unknown");
-    child::run(log, cmd, "cargo build").context("Compiling your crate to WebAssembly")?;
+    child::run(log, cmd, "cargo build").context("Compiling your crate to WebAssembly failed")?;
     Ok(())
 }
 

src/child.rs

@@ -171,7 +171,6 @@ pub fn run(
     if exit.success() {
         return Ok(stdout);
     } else {
-        let msg = format!("`{}` did not exit successfully", command_name);
+        return Err(Error::cli(command_name, stdout.into(), stderr.into(), exit).into());
-        return Err(Error::cli(&msg, stdout.into(), stderr.into(), exit).into());
     }
 }

src/error.rs

@@ -47,13 +47,10 @@ pub enum Error {
     },
 
     /// An error invoking another CLI tool.
-    #[fail(
+    #[fail(display = "`{}` exited with {}", tool, exit_status)]
-        display = "Process exited with {}: {}.\n\nstdout:{}\n\nstderr:\n\n{}",
-        exit_status, message, stdout, stderr
-    )]
     Cli {
         /// Error message.
-        message: String,
+        tool: String,
         /// The underlying CLI's `stdout` output.
         stdout: String,
         /// The underlying CLI's `stderr` output.
@@ -101,9 +98,9 @@ pub enum Error {
 
 impl Error {
     /// Construct a CLI error.
-    pub fn cli(message: &str, stdout: Cow<str>, stderr: Cow<str>, exit_status: ExitStatus) -> Self {
+    pub fn cli(tool: &str, stdout: Cow<str>, stderr: Cow<str>, exit_status: ExitStatus) -> Self {
         Error::Cli {
-            message: message.to_string(),
+            tool: tool.to_string(),
             stdout: stdout.to_string(),
             stderr: stderr.to_string(),
             exit_status,
@@ -161,7 +158,7 @@ impl Error {
               local_minor_version: _,
             } => "Your rustc version is not supported. Please install version 1.30.0 or higher.",
             Error::Cli {
-                message: _,
+                tool: _,
                 stdout: _,
                 stderr: _,
                 exit_status: _,

src/main.rs

@@ -16,7 +16,7 @@ mod installer;
 fn main() {
     setup_panic!();
     if let Err(e) = run() {
-        eprintln!("{}", e);
+        eprintln!("Error: {}", e);
         for cause in e.iter_causes() {
             eprintln!("Caused by: {}", cause);
         }