remove exposing local interface when serving a domain

1 year ago · ce9069ebb0
parent 8897cc5444
commit ce9069ebb0
1 changed files with 8 additions and 7 deletions
--- a/p2p-net/src/types.rs
+++ b/p2p-net/src/types.rs
@ -1142,13 +1142,14 @@ impl ListenerV0 {
                        self.accept_forward_for.get_domain().to_string(),
                    ));
                }
-                if self.accept_direct {
-                    if self.if_type == InterfaceType::Private {
-                        res.push(BrokerServerTypeV0::BoxPrivate(addrs));
-                    } else if self.if_type == InterfaceType::Loopback {
-                        res.push(BrokerServerTypeV0::Localhost(addrs[0].port));
-                    }
-                }
+                //// this is removed since a server serving domain requests often needs a local interface too (for ngaccount), but does not want to expose this local interface to clients.
+                // if self.accept_direct {
+                //     if self.if_type == InterfaceType::Private {
+                //         res.push(BrokerServerTypeV0::BoxPrivate(addrs));
+                //     } else if self.if_type == InterfaceType::Loopback {
+                //         res.push(BrokerServerTypeV0::Localhost(addrs[0].port));
+                //     }
+                // }
            }
            AcceptForwardForV0::PrivateDomain(_) => {
                res.push(BrokerServerTypeV0::Domain(