NextGraph
/
nextgraph-rs
1
2
Fork 0
Code Issues 1 Pull Requests Packages Projects 2 Releases 3 Activity
Labels Milestones

ngaccount: change hard-coded server ip and create note in readme #21

Closed
laurin wants to merge 2 commits from fix/ngaccount-ip into master
Conversation 2 Commits 2 Files Changed 6
laurin commented 5 months ago
Collaborator

@niko you said:

you can revert your local changes related to ngaccount and the IP addresses, because we should not need that anymore. maybe you can document somewhere what you had to change in order to create your dev env wallet

I'm not sure exactly how to document. I suppose, the way it is set up now, works locally? Or is it mandatory to use an IP from your lan? Anyway, I created a note, created an .env file and updated the readme.

@niko you said: > you can revert your local changes related to ngaccount and the IP addresses, because we should not need that anymore. maybe you can document somewhere what you had to change in order to create your dev env wallet I'm not sure exactly how to document. I suppose, the way it is set up now, works locally? Or is it mandatory to use an IP from your lan? Anyway, I created a note, created an `.env` file and updated the readme.
laurin added 1 commit 5 months ago
laurin force-pushed fix/ngaccount-ip from 1051f80306 to 88742141e3 5 months ago
niko commented 5 months ago
Owner

nice.
I had configured all those URLs with my LAN IP when I was testing the creation of a wallet on android.
As you know the localhost doesnt work on android emulator, so I was testing on a real android device which was connected to the LAn with Wifi, so it could reach ngaccount server.
All of that is not needed anymore, specially because I found a fix for the localhost access from android emulator.
Can you put somehwere in a README the link that explains how to configure android emulator to access locahost with a reverse proxy?

nice. I had configured all those URLs with my LAN IP when I was testing the creation of a wallet on android. As you know the localhost doesnt work on android emulator, so I was testing on a real android device which was connected to the LAn with Wifi, so it could reach ngaccount server. All of that is not needed anymore, specially because I found a fix for the localhost access from android emulator. Can you put somehwere in a README the link that explains how to configure android emulator to access locahost with a reverse proxy?
laurin added 1 commit 5 months ago
laurin force-pushed fix/ngaccount-ip from 9223ea16d9 to 8e8b08d2fc 5 months ago
laurin commented 5 months ago
Poster
Collaborator

Thanks for the context! :)
I added that to the README.

Thanks for the context! :) I added that to the README.
niko closed this pull request 4 months ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
native android native ios native linux native macos native windows web client
bug
Something is not working coding duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong p2p repo project mng question
More information is needed sites sysadmin wontfix
This won't be fixed
No Label native android native ios native linux native macos native windows web client bug coding duplicate enhancement help wanted invalid p2p repo project mng question sites sysadmin wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NextGraph/nextgraph-rs#21
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/ngaccount-ip'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes