NextGraph
/
rocksdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix old comment about HyperClockCache and SecondaryCache (#11517)

Browse Source 
Summary:
Support was added in 8.1.0

Pull Request resolved: https://github.com/facebook/rocksdb/pull/11517

Test Plan: comments only

Reviewed By: anand1976

Differential Revision: D46489929

Pulled By: pdillinger

fbshipit-source-id: 4fd30078389065c9ec225bf55b6773f1641f0646
oxigraph-main
Peter Dillinger 1 year ago committed by Facebook GitHub Bot
parent 3093d98c78
commit 2b2994c8db
1 changed files with 0 additions and 1 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 1
      include/rocksdb/cache.h

1
include/rocksdb/cache.h
Unescape View File

@ -376,7 +376,6 @@ inline std::shared_ptr<SecondaryCache> NewCompressedSecondaryCache(
// * Requires an extra tuning parameter: see estimated_entry_charge below. // * Requires an extra tuning parameter: see estimated_entry_charge below.
// Similarly, substantially changing the capacity with SetCapacity could // Similarly, substantially changing the capacity with SetCapacity could
// harm efficiency. // harm efficiency.
// * SecondaryCache is not yet supported.
// * Cache priorities are less aggressively enforced, which could cause // * Cache priorities are less aggressively enforced, which could cause
// cache dilution from long range scans (unless they use fill_cache=false). // cache dilution from long range scans (unless they use fill_cache=false).
// * Can be worse for small caches, because if almost all of a cache shard is // * Can be worse for small caches, because if almost all of a cache shard is

Write Preview
Loading…
Cancel
Save