Merge pull request #253 from iSynaptic/ergonomics-and-safety
Ergonomics and safety improvementsmaster
Jordan Terrell
6 years ago
committed by
GitHub
commit
13be813880
@ -0,0 +1,51 @@ |
|||||||
|
// Copyright 2019 Tyler Neely
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
// you may not use this file except in compliance with the License.
|
||||||
|
// You may obtain a copy of the License at
|
||||||
|
//
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
//
|
||||||
|
// Unless required by applicable law or agreed to in writing, software
|
||||||
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
// See the License for the specific language governing permissions and
|
||||||
|
// limitations under the License.
|
||||||
|
|
||||||
|
extern crate rocksdb; |
||||||
|
|
||||||
|
mod util; |
||||||
|
|
||||||
|
use rocksdb::{CompactionDecision, DB, Options}; |
||||||
|
use util::DBPath; |
||||||
|
|
||||||
|
#[cfg(test)] |
||||||
|
#[allow(unused_variables)] |
||||||
|
fn test_filter(level: u32, key: &[u8], value: &[u8]) -> CompactionDecision { |
||||||
|
use self::CompactionDecision::*; |
||||||
|
match key.first() { |
||||||
|
Some(&b'_') => Remove, |
||||||
|
Some(&b'%') => Change(b"secret"), |
||||||
|
_ => Keep, |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
#[test] |
||||||
|
fn compaction_filter_test() { |
||||||
|
use {Options, DB}; |
||||||
|
|
||||||
|
let path = DBPath::new("_rust_rocksdb_filtertest"); |
||||||
|
let mut opts = Options::default(); |
||||||
|
opts.create_if_missing(true); |
||||||
|
opts.set_compaction_filter("test", test_filter); |
||||||
|
{ |
||||||
|
let db = DB::open(&opts, &path).unwrap(); |
||||||
|
let _ = db.put(b"k1", b"a"); |
||||||
|
let _ = db.put(b"_k", b"b"); |
||||||
|
let _ = db.put(b"%k", b"c"); |
||||||
|
db.compact_range(None::<&[u8]>, None::<&[u8]>); |
||||||
|
assert_eq!(&*db.get(b"k1").unwrap().unwrap(), b"a"); |
||||||
|
assert!(db.get(b"_k").unwrap().is_none()); |
||||||
|
assert_eq!(&*db.get(b"%k").unwrap().unwrap(), b"secret"); |
||||||
|
} |
||||||
|
} |
||||||
@ -0,0 +1,181 @@ |
|||||||
|
// Copyright 2019 Tyler Neely
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
// you may not use this file except in compliance with the License.
|
||||||
|
// You may obtain a copy of the License at
|
||||||
|
//
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
//
|
||||||
|
// Unless required by applicable law or agreed to in writing, software
|
||||||
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
// See the License for the specific language governing permissions and
|
||||||
|
// limitations under the License.
|
||||||
|
|
||||||
|
extern crate rocksdb; |
||||||
|
extern crate libc; |
||||||
|
|
||||||
|
mod util; |
||||||
|
|
||||||
|
use libc::{size_t}; |
||||||
|
|
||||||
|
use rocksdb::{DB, DBVector, Error, IteratorMode, Options, WriteBatch}; |
||||||
|
use util::DBPath; |
||||||
|
|
||||||
|
#[test] |
||||||
|
fn test_db_vector() { |
||||||
|
use std::mem; |
||||||
|
let len: size_t = 4; |
||||||
|
let data: *mut u8 = unsafe { mem::transmute(libc::calloc(len, mem::size_of::<u8>())) }; |
||||||
|
let v = unsafe { DBVector::from_c(data, len) }; |
||||||
|
let ctrl = [0u8, 0, 0, 0]; |
||||||
|
assert_eq!(&*v, &ctrl[..]); |
||||||
|
} |
||||||
|
|
||||||
|
#[test] |
||||||
|
fn external() { |
||||||
|
let path = DBPath::new("_rust_rocksdb_externaltest"); |
||||||
|
|
||||||
|
{ |
||||||
|
let db = DB::open_default(&path).unwrap(); |
||||||
|
|
||||||
|
assert!(db.put(b"k1", b"v1111").is_ok()); |
||||||
|
|
||||||
|
let r: Result<Option<DBVector>, Error> = db.get(b"k1"); |
||||||
|
|
||||||
|
assert!(r.unwrap().unwrap().to_utf8().unwrap() == "v1111"); |
||||||
|
assert!(db.delete(b"k1").is_ok()); |
||||||
|
assert!(db.get(b"k1").unwrap().is_none()); |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
#[test] |
||||||
|
fn errors_do_stuff() { |
||||||
|
let path = DBPath::new("_rust_rocksdb_error"); |
||||||
|
let _db = DB::open_default(&path).unwrap(); |
||||||
|
let opts = Options::default(); |
||||||
|
// The DB will still be open when we try to destroy it and the lock should fail.
|
||||||
|
match DB::destroy(&opts, &path) { |
||||||
|
Err(s) => { |
||||||
|
let message = s.to_string(); |
||||||
|
assert!(message.find("IO error:").is_some()); |
||||||
|
assert!(message.find("_rust_rocksdb_error").is_some()); |
||||||
|
assert!(message.find("/LOCK:").is_some()); |
||||||
|
} |
||||||
|
Ok(_) => panic!("should fail"), |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
#[test] |
||||||
|
fn writebatch_works() { |
||||||
|
let path = DBPath::new("_rust_rocksdb_writebacktest"); |
||||||
|
{ |
||||||
|
let db = DB::open_default(&path).unwrap(); |
||||||
|
{ |
||||||
|
// test put
|
||||||
|
let mut batch = WriteBatch::default(); |
||||||
|
assert!(db.get(b"k1").unwrap().is_none()); |
||||||
|
assert_eq!(batch.len(), 0); |
||||||
|
assert!(batch.is_empty()); |
||||||
|
let _ = batch.put(b"k1", b"v1111"); |
||||||
|
assert_eq!(batch.len(), 1); |
||||||
|
assert!(!batch.is_empty()); |
||||||
|
assert!(db.get(b"k1").unwrap().is_none()); |
||||||
|
assert!(db.write(batch).is_ok()); |
||||||
|
let r: Result<Option<DBVector>, Error> = db.get(b"k1"); |
||||||
|
assert!(r.unwrap().unwrap().to_utf8().unwrap() == "v1111"); |
||||||
|
} |
||||||
|
{ |
||||||
|
// test delete
|
||||||
|
let mut batch = WriteBatch::default(); |
||||||
|
let _ = batch.delete(b"k1"); |
||||||
|
assert_eq!(batch.len(), 1); |
||||||
|
assert!(!batch.is_empty()); |
||||||
|
assert!(db.write(batch).is_ok()); |
||||||
|
assert!(db.get(b"k1").unwrap().is_none()); |
||||||
|
} |
||||||
|
{ |
||||||
|
// test size_in_bytes
|
||||||
|
let mut batch = WriteBatch::default(); |
||||||
|
let before = batch.size_in_bytes(); |
||||||
|
let _ = batch.put(b"k1", b"v1234567890"); |
||||||
|
let after = batch.size_in_bytes(); |
||||||
|
assert!(before + 10 <= after); |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
#[test] |
||||||
|
fn iterator_test() { |
||||||
|
let path = DBPath::new("_rust_rocksdb_iteratortest"); |
||||||
|
{ |
||||||
|
let data = [(b"k1", b"v1111"), (b"k2", b"v2222"), (b"k3", b"v3333")]; |
||||||
|
let db = DB::open_default(&path).unwrap(); |
||||||
|
|
||||||
|
for (key, value) in &data { |
||||||
|
assert!(db.put(key, value).is_ok()); |
||||||
|
} |
||||||
|
|
||||||
|
let iter = db.iterator(IteratorMode::Start); |
||||||
|
|
||||||
|
for (idx, (db_key, db_value)) in iter.enumerate() { |
||||||
|
let (key, value) = data[idx]; |
||||||
|
assert_eq!((&key[..], &value[..]), (db_key.as_ref(), db_value.as_ref())); |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
#[test] |
||||||
|
fn snapshot_test() { |
||||||
|
let path = DBPath::new("_rust_rocksdb_snapshottest"); |
||||||
|
{ |
||||||
|
let db = DB::open_default(&path).unwrap(); |
||||||
|
|
||||||
|
assert!(db.put(b"k1", b"v1111").is_ok()); |
||||||
|
|
||||||
|
let snap = db.snapshot(); |
||||||
|
assert!(snap.get(b"k1").unwrap().unwrap().to_utf8().unwrap() == "v1111"); |
||||||
|
|
||||||
|
assert!(db.put(b"k2", b"v2222").is_ok()); |
||||||
|
|
||||||
|
assert!(db.get(b"k2").unwrap().is_some()); |
||||||
|
assert!(snap.get(b"k2").unwrap().is_none()); |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
#[test] |
||||||
|
fn set_option_test() { |
||||||
|
let path = DBPath::new("_rust_rocksdb_set_optionstest"); |
||||||
|
{ |
||||||
|
let db = DB::open_default(&path).unwrap(); |
||||||
|
// set an option to valid values
|
||||||
|
assert!(db |
||||||
|
.set_options(&[("disable_auto_compactions", "true")]) |
||||||
|
.is_ok()); |
||||||
|
assert!(db |
||||||
|
.set_options(&[("disable_auto_compactions", "false")]) |
||||||
|
.is_ok()); |
||||||
|
// invalid names/values should result in an error
|
||||||
|
assert!(db |
||||||
|
.set_options(&[("disable_auto_compactions", "INVALID_VALUE")]) |
||||||
|
.is_err()); |
||||||
|
assert!(db |
||||||
|
.set_options(&[("INVALID_NAME", "INVALID_VALUE")]) |
||||||
|
.is_err()); |
||||||
|
// option names/values must not contain NULLs
|
||||||
|
assert!(db |
||||||
|
.set_options(&[("disable_auto_compactions", "true\0")]) |
||||||
|
.is_err()); |
||||||
|
assert!(db |
||||||
|
.set_options(&[("disable_auto_compactions\0", "true")]) |
||||||
|
.is_err()); |
||||||
|
// empty options are not allowed
|
||||||
|
assert!(db.set_options(&[]).is_err()); |
||||||
|
// multiple options can be set in a single API call
|
||||||
|
let multiple_options = [ |
||||||
|
("paranoid_file_checks", "true"), |
||||||
|
("report_bg_io_stats", "true"), |
||||||
|
]; |
||||||
|
db.set_options(&multiple_options).unwrap(); |
||||||
|
} |
||||||
|
} |
||||||
Loading…
Reference in new issue