Methods `crate_cf` and `drop_cf` are immutable.

master
Oleksandr Anyshchenko 6 years ago
parent 0475bbeaea
commit 8863012a19
  1. 36
      src/db.rs
  2. 3
      src/lib.rs
  3. 4
      tests/test_column_family.rs

@ -28,6 +28,7 @@ use std::path::Path;
use std::ptr; use std::ptr;
use std::slice; use std::slice;
use std::str; use std::str;
use std::sync::{Arc, RwLock};
pub fn new_bloom_filter(bits: c_int) -> *mut ffi::rocksdb_filterpolicy_t { pub fn new_bloom_filter(bits: c_int) -> *mut ffi::rocksdb_filterpolicy_t {
unsafe { ffi::rocksdb_filterpolicy_create_bloom(bits) } unsafe { ffi::rocksdb_filterpolicy_create_bloom(bits) }
@ -630,7 +631,7 @@ impl DB {
} }
let db: *mut ffi::rocksdb_t; let db: *mut ffi::rocksdb_t;
let mut cf_map = BTreeMap::new(); let cf_map = Arc::new(RwLock::new(BTreeMap::new()));
if cfs.len() == 0 { if cfs.len() == 0 {
unsafe { unsafe {
@ -682,7 +683,7 @@ impl DB {
} }
for (n, h) in cfs_v.iter().zip(cfhandles) { for (n, h) in cfs_v.iter().zip(cfhandles) {
cf_map.insert(n.name.clone(), ColumnFamily { inner: h }); cf_map.write().unwrap().insert(n.name.clone(), ColumnFamily { inner: h });
} }
} }
@ -838,7 +839,7 @@ impl DB {
self.get_cf_opt(cf, key, &ReadOptions::default()) self.get_cf_opt(cf, key, &ReadOptions::default())
} }
pub fn create_cf(&mut self, name: &str, opts: &Options) -> Result<ColumnFamily, Error> { pub fn create_cf(&self, name: &str, opts: &Options) -> Result<ColumnFamily, Error> {
let cname = match CString::new(name.as_bytes()) { let cname = match CString::new(name.as_bytes()) {
Ok(c) => c, Ok(c) => c,
Err(_) => { Err(_) => {
@ -856,31 +857,28 @@ impl DB {
cname.as_ptr(), cname.as_ptr(),
)); ));
let cf = ColumnFamily { inner: cf_handler }; let cf = ColumnFamily { inner: cf_handler };
self.cfs.insert(name.to_string(), cf); self.cfs.write().unwrap().insert(name.to_string(), cf);
cf cf
}; };
Ok(cf) Ok(cf)
} }
pub fn drop_cf(&mut self, name: &str) -> Result<(), Error> { pub fn drop_cf(&self, name: &str) -> Result<(), Error> {
let cf = self.cfs.get(name); if let Some(cf) = self.cfs.write().unwrap().remove(name) {
if cf.is_none() { unsafe {
return Err(Error::new( ffi_try!(ffi::rocksdb_drop_column_family(self.inner, cf.inner,));
format!("Invalid column family: {}", name).to_owned(), }
)); Ok(())
} } else {
unsafe { Err(Error::new(
ffi_try!(ffi::rocksdb_drop_column_family( format!("Invalid column family: {}", name).to_owned()
self.inner, ))
cf.unwrap().inner,
));
} }
Ok(())
} }
/// Return the underlying column family handle. /// Return the underlying column family handle.
pub fn cf_handle(&self, name: &str) -> Option<ColumnFamily> { pub fn cf_handle(&self, name: &str) -> Option<ColumnFamily> {
self.cfs.get(name).cloned() self.cfs.read().unwrap().get(name).cloned()
} }
pub fn iterator(&self, mode: IteratorMode) -> DBIterator { pub fn iterator(&self, mode: IteratorMode) -> DBIterator {
@ -1207,7 +1205,7 @@ impl Drop for WriteBatch {
impl Drop for DB { impl Drop for DB {
fn drop(&mut self) { fn drop(&mut self) {
unsafe { unsafe {
for cf in self.cfs.values() { for cf in self.cfs.read().unwrap().values() {
ffi::rocksdb_column_family_handle_destroy(cf.inner); ffi::rocksdb_column_family_handle_destroy(cf.inner);
} }
ffi::rocksdb_close(self.inner); ffi::rocksdb_close(self.inner);

@ -72,13 +72,14 @@ use std::collections::BTreeMap;
use std::error; use std::error;
use std::fmt; use std::fmt;
use std::path::PathBuf; use std::path::PathBuf;
use std::sync::{Arc, RwLock};
/// A RocksDB database. /// A RocksDB database.
/// ///
/// See crate level documentation for a simple usage example. /// See crate level documentation for a simple usage example.
pub struct DB { pub struct DB {
inner: *mut ffi::rocksdb_t, inner: *mut ffi::rocksdb_t,
cfs: BTreeMap<String, ColumnFamily>, cfs: Arc<RwLock<BTreeMap<String, ColumnFamily>>>,
path: PathBuf, path: PathBuf,
} }

@ -25,7 +25,7 @@ pub fn test_column_family() {
let mut opts = Options::default(); let mut opts = Options::default();
opts.create_if_missing(true); opts.create_if_missing(true);
opts.set_merge_operator("test operator", test_provided_merge, None); opts.set_merge_operator("test operator", test_provided_merge, None);
let mut db = DB::open(&opts, path).unwrap(); let db = DB::open(&opts, path).unwrap();
let opts = Options::default(); let opts = Options::default();
match db.create_cf("cf1", &opts) { match db.create_cf("cf1", &opts) {
Ok(_) => println!("cf1 created successfully"), Ok(_) => println!("cf1 created successfully"),
@ -81,7 +81,7 @@ pub fn test_column_family() {
} }
// should b able to drop a cf // should b able to drop a cf
{ {
let mut db = DB::open_cf(&Options::default(), path, &["cf1"]).unwrap(); let db = DB::open_cf(&Options::default(), path, &["cf1"]).unwrap();
match db.drop_cf("cf1") { match db.drop_cf("cf1") {
Ok(_) => println!("cf1 successfully dropped."), Ok(_) => println!("cf1 successfully dropped."),
Err(e) => panic!("failed to drop column family: {}", e), Err(e) => panic!("failed to drop column family: {}", e),

Loading…
Cancel
Save